allow renaming function Params structs#3878
Open
skandragon wants to merge 1 commit intosqlc-dev:mainfrom
Open
Conversation
Author
|
Any chance this can be merged, or feedback on what it would take? |
92394a9 to
567d8bd
Compare
Author
|
bump. |
7242e00 to
7a2d750
Compare
7a2d750 to
dbd26c3
Compare
dbd26c3 to
eddb736
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a case where I want to wrap some of the database calls in some internal layers, and would like to have a single params structure that is exposed between my hand-rolled wrapped code and the generated names.
Specifically, I am making a function called
UpsertFooUncachedusing code gen and I want a cached version:In this case, I could use
type UpsertFooParams UpsertFooUncachedParamsbut this doesn't work well for users as it doesn't always expand with VSCode, so the internals are a mystery. I could recreate the structure, but then I need to keep it in sync. I could embed the Uncached version, but then using it is a pain.I'd like to rename, and this change seems to do the trick.